fix: Reading Parquet with Null dictionary page #18112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18112 +/- ##
==========================================
- Coverage 80.37% 80.33% -0.04%
==========================================
Files 1496 1496
Lines 197542 197683 +141
Branches 2820 2821 +1
==========================================
+ Hits 158771 158811 +40
- Misses 38249 38351 +102
+ Partials 522 521 -1 ☔ View full report in Codecov by Sentry. |
|
Nice. Can you add this test? import pandas as pd
test = pd.DataFrame([{'A':np.NaN,'B':3,'C':None},{'A':np.NaN,'B':None,'C':None}])
test.to_parquet('~/mre.parquet')
pl.scan_parquet('~/mre.parquet').collect() Slightly adapted so that it writes to a bytes buffer. |
coastalwhite
requested review from
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
|
Did it 👍 |
This fixes an issue with some Parquet writers that write dictionary pages for Null arrays (why?? I have no idea?). Fixes pola-rs#18085. Fixes pola-rs#18079. Possibly also pola-rs#18061.
coastalwhite
force-pushed
the
fix-parquet-null-dictionary-page
branch
from
1c0523d
to
3be3ac0
Compare
ritchie46
reviewed
Aug 9, 2024
coastalwhite
force-pushed
the
fix-parquet-null-dictionary-page
branch
2 times, most recently
from
6756f0c
to
c1eacf0
Compare
coastalwhite
force-pushed
the
fix-parquet-null-dictionary-page
branch
from
c1eacf0
to
9d2ed1a
Compare
ritchie46
approved these changes
Aug 9, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with some Parquet writers that write dictionary pages for Null arrays (why?? I have no idea?).
Fixes #18085.
Fixes #18079.
Possibly also #18061.